Windows client is not ending cleanly

General Clan Lord discussion

Moderator: CL GMs

User avatar
thesquib
Exile
Posts: 120
Joined: Tue Apr 03, 2007 2:02 am
Profession: Fighter
Race: Dwarf
Player Status: Active

Re: Windows client is not ending cleanly

Post by thesquib » Tue Jan 09, 2018 12:00 am

A possible answer to the problem of the dll being flagged or removed by AV is to ask the person building the windows version to stop using UPX during the release build. This should be easy to do, maybe doesn't even require code changes! Just removing a step from the build process.

Anti-virus engines pick this up because it is simply used in malware everywhere. It's possible updating UPX might help prevent being flagged, I don't know. Packing the dll is probably pointless anyway, because someone can just debug the thing in memory once it is loaded.

Background info on UPX:
https://en.wikipedia.org/wiki/UPX
HWC Ruuk

User avatar
Yappy
CL GM
CL GM
Posts: 342
Joined: Fri Jul 27, 2007 1:48 am
Profession: GM
Race: Concealed
Player Status: Active

Re: Windows client is not ending cleanly

Post by Yappy » Tue Jan 09, 2018 8:07 am

I'll pass this info along, thanks.

User avatar
thesquib
Exile
Posts: 120
Joined: Tue Apr 03, 2007 2:02 am
Profession: Fighter
Race: Dwarf
Player Status: Active

Re: Windows client is not ending cleanly

Post by thesquib » Tue Jan 09, 2018 11:57 pm

Yappy I've just confirmed that I can unpack the client DLL using UPX (command is upx -d) and the client still runs fine. The DLL is about 3x the size (1.8mb or so). Windows Defender does not try and delete the dll after it is unpacked.

So I guess that means the DLL is packed simply to save some space, in which case the packing can be disabled without any problem.

Still doesn't solve the Quicktime dependency for sound though!
HWC Ruuk

User avatar
Yappy
CL GM
CL GM
Posts: 342
Joined: Fri Jul 27, 2007 1:48 am
Profession: GM
Race: Concealed
Player Status: Active

Re: Windows client is not ending cleanly

Post by Yappy » Sat Jan 13, 2018 7:04 am

ServerGM will give this a try for the v1052 update and we'll see how it goes!

Whirl wind
Exile
Posts: 74
Joined: Sat Aug 21, 2010 1:24 pm
Profession: Sky Mystic
Race: Human
Player Status: Active
Location: Up Where the Air is Thin
Contact:

Re: Windows client is not ending cleanly

Post by Whirl wind » Sat Jan 13, 2018 10:24 pm

You're the hero we needed Squib.
Who needs the Mainland? I've got a floating island!

User avatar
Icy
Noble
Posts: 1024
Joined: Mon Jan 03, 2005 7:14 pm
Profession: All
Race: Dwarf
Player Status: Inactive

Re: Windows client is not ending cleanly

Post by Icy » Thu Jan 18, 2018 11:19 am

Neat, although I don't think that Antivirus deleting/removing/quarantining the dll has anything to do with the client not ending cleanly. I still believe that's due to wxWidgets. :wink:
3/3/15 9:27:45a Icy has fallen to a Rat.

User avatar
thesquib
Exile
Posts: 120
Joined: Tue Apr 03, 2007 2:02 am
Profession: Fighter
Race: Dwarf
Player Status: Active

Re: Windows client is not ending cleanly

Post by thesquib » Thu Jan 18, 2018 12:05 pm

Oh yeah sorry Icy, I guess we stole your thread :cry:
HWC Ruuk

User avatar
thesquib
Exile
Posts: 120
Joined: Tue Apr 03, 2007 2:02 am
Profession: Fighter
Race: Dwarf
Player Status: Active

Re: Windows client is not ending cleanly

Post by thesquib » Thu Jan 25, 2018 6:50 pm

Icy, did it improve your issue? I've run the new client on Windows 10 1709, and it seems to be fine.
HWC Ruuk

User avatar
Icy
Noble
Posts: 1024
Joined: Mon Jan 03, 2005 7:14 pm
Profession: All
Race: Dwarf
Player Status: Inactive

Re: Windows client is not ending cleanly

Post by Icy » Fri Jan 26, 2018 8:19 am

Nope.

Image
3/3/15 9:27:45a Icy has fallen to a Rat.

User avatar
Yappy
CL GM
CL GM
Posts: 342
Joined: Fri Jul 27, 2007 1:48 am
Profession: GM
Race: Concealed
Player Status: Active

Re: Windows client is not ending cleanly

Post by Yappy » Sat Jan 27, 2018 1:36 am

Icy wrote:
Fri Jan 26, 2018 8:19 am
Nope.
Nuts.

User avatar
Icy
Noble
Posts: 1024
Joined: Mon Jan 03, 2005 7:14 pm
Profession: All
Race: Dwarf
Player Status: Inactive

Re: Windows client is not ending cleanly

Post by Icy » Sat Jan 27, 2018 12:32 pm

If server GM wanted to give me CVS credentials or this directory from their machine I could take a crack at it: c:\Develop\Arindal_Winclient\CVSROOT\winclient\client\obj\vc9\clanlord-release

also who wrote this? and why's there a reference to this song in it? digging it
Image
3/3/15 9:27:45a Icy has fallen to a Rat.

User avatar
Icy
Noble
Posts: 1024
Joined: Mon Jan 03, 2005 7:14 pm
Profession: All
Race: Dwarf
Player Status: Inactive

Re: Windows client is not ending cleanly

Post by Icy » Mon Jan 29, 2018 7:41 am

It also looks like this is a problem even for the final Arindal client.
Image
3/3/15 9:27:45a Icy has fallen to a Rat.

Post Reply